Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [parser] LiteralBuffer::ExpandBuffer always grows #18568

Merged
merged 3 commits into from Jun 4, 2019
Merged

fix: [parser] LiteralBuffer::ExpandBuffer always grows #18568

merged 3 commits into from Jun 4, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 1, 2019

Description of Change

Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=914736
https://chromium.googlesource.com/v8/v8.git/+/c7410e8ccff855fdb1a1a0a0c6c2690716a96548

[parser] LiteralBuffer::ExpandBuffer always grows

/cc @electron/wg-security

Checklist

Release Notes

Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=914736.

@miniak miniak added the 4-2-x label Jun 1, 2019
@miniak miniak requested a review from a team June 1, 2019 22:37
@miniak miniak self-assigned this Jun 1, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 1, 2019
@miniak miniak changed the title fix: Issue 914736: Security: Heap buffer overflow in the V8 language parser fix: [parser] LiteralBuffer::ExpandBuffer always grows Jun 1, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 2, 2019
@miniak miniak added security 🔒 backport This is a backport PR labels Jun 3, 2019
@jkleinsc jkleinsc merged commit df60a80 into 4-2-x Jun 4, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 4, 2019

Release Notes Persisted

Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=914736.

@miniak miniak deleted the miniak/backport-914736-4-2-x branch June 14, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees

@miniak miniak

Labels
4-2-x backport This is a backport PR security 🔒
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @nornagon @zcbenz @jkleinsc