build: fix v8 symbols for Windows on Arm #18592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excluding the host-toolchain from symbol exports means that the Windows on Arm build requires fewer workarounds.
jkleinsc
approved these changes
Jun 3, 2019
deepak1556
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
LGTM, but this new check can be combined into the condition for macro HIDE_PRIVATE_SYMBOLS introduced in #18281 since they are trying to achieve the same.
|
@richard-townsend-arm please fix patch conflicts and address deepak's review above when you have a moment! |
|
Hi (apologies, this fell off the end of my to-do list), it seems that #18281 fixed the build error for me, so closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adjusts V8 symbol visibility so that symbols are kept private for the host toolchain and are exposed for the target toolchain, which means significantly fewer workarounds are needed for symbol visibility on Windows on Arm.
Checklist
Release Notes
Notes: no-notes