Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lost window.opener after cross-origin navigation #18624

Merged
merged 2 commits into from Jun 11, 2019
Merged

fix: lost window.opener after cross-origin navigation #18624

merged 2 commits into from Jun 11, 2019

Conversation

alexstrat
Copy link
Contributor

@alexstrat alexstrat commented Jun 4, 2019 •
edited

Description of Change

Backport of #18173

Checklist

Release Notes

Notes: Fixed window.opener null after cross-origin navigation

@alexstrat alexstrat requested a review from a team as a code owner June 4, 2019 12:45
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 4, 2019
@trop trop bot mentioned this pull request Jun 4, 2019
Merged
5 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 5, 2019
@alexstrat alexstrat changed the title [WIP] fix: lost window.opener after cross-origin navigation fix: lost window.opener after cross-origin navigation Jun 6, 2019
@alexstrat
Copy link
Contributor Author

alexstrat commented Jun 6, 2019 •
edited

Failing test on MacOs for an unrelated reason, see #17649 Fixed with a new build

codebytere
codebytere approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but paging @MarshallOfSound or @deepak1556 for secondary opinion before we merge.

@codebytere codebytere added 6-0-x backport This is a backport PR labels Jun 7, 2019
@codebytere codebytere merged commit 6d9d66b into electron:6-0-x Jun 11, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 11, 2019

Release Notes Persisted

Fixed window.opener null after cross-origin navigation

@deepak1556 deepak1556 mentioned this pull request Jun 18, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
6-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexstrat @deepak1556 @codebytere