Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use isEqual instead of pointer equality to convert NSAppearance #18665

Merged
merged 1 commit into from Jun 7, 2019
Merged

fix: use isEqual instead of pointer equality to convert NSAppearance #18665

merged 1 commit into from Jun 7, 2019

Conversation

MarshallOfSound
Copy link
Member

Yeah so this sometimes worked, but sometimes doesn't. We should be checking string equality not pointer equality.

Notes: Fixed issue where getEffectiveApperance and getAppLevelAppearance would return unknown instead of the correct value sometimes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 6, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 7, 2019
@codebytere codebytere merged commit a9f6016 into master Jun 7, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 7, 2019

Release Notes Persisted

Fixed issue where getEffectiveApperance and getAppLevelAppearance would return unknown instead of the correct value sometimes

@codebytere codebytere deleted the fix-appearance-converters branch June 7, 2019 16:55
@trop trop bot mentioned this pull request Jun 7, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jun 7, 2019

I have automatically backported this PR to "5-0-x", please check out #18689

@trop trop bot mentioned this pull request Jun 7, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jun 7, 2019

I have automatically backported this PR to "6-0-x", please check out #18690

@trop trop bot mentioned this pull request Jun 7, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jun 7, 2019

I have automatically backported this PR to "4-2-x", please check out #18691

@sofianguy sofianguy added this to Fixed in 6.0.0-beta.7 in 6.1.x Jun 11, 2019
@sofianguy sofianguy added this to Fixed in 5.0.4 in 5.0.x Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.4
6.1.x
Fixed in 6.0.0-beta.7
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarshallOfSound @miniak @codebytere