New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add creationTime / sandboxed / integrityLevel to app.getAppMetrics() #18718
Conversation
06e0890
to
d6a912a
Compare
e9d67e8
to
a23362e
Compare
a23362e
to
a12df50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me. Since this is new API, I'd like to see more feedback from other maintainers instead of landing it now.
As an aside, it often seems like there's hesitancy to jump on PRs that involve new API / API changes. Maybe we should revisit the idea of an API WG so that the roles are clearer. Since that doesn't exist right now, though -- CC'ing @electron/wg-releases for feedback?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new API looks good to me.
Release Notes Persisted
|
I think this could add support for linux by reading the value of But to make this return useful value in mixed sandbox mode were we bypass zygote https://github.com/electron/electron/blob/master/patches/chromium/support_mixed_sandbox_with_zygote.patch, maybe check for /cc @nornagon |
Hmm, I don't think sandbox status of the zygote tells you whether or not the process is sandboxed, because the way we implement mixed-sandbox mode in linux is that sandboxed processes are launched through the zygote and unsandboxed processes are launched directly. |
Description of Change
This is useful for checking which processes are sandboxed on OS level.
Regarding
creationTime
, since thepid
can be reused after a process dies, it is useful to use both thepid
and thecreationTime
to uniquely identify a process.Required for tests in #18650
/cc @MarshallOfSound, @deepak1556
Checklist
npm test
passesRelease Notes
Notes: Added
creationTime
/sandboxed
/integrityLevel
toapp.getAppMetrics()
output.