Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: HTML fullscreen request for sub frames #18736

Merged
merged 1 commit into from Jun 13, 2019
Merged

fix: HTML fullscreen request for sub frames #18736

merged 1 commit into from Jun 13, 2019

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Jun 11, 2019 •
edited

Description of Change

Don't re-enter fullscreen if there is a pending operation, for subframe fullscreen request EnterFullScreenModeForTab will be called for both the frame in question as well as the outer webContents hosting it.

Fixes #18188

Checklist

Release Notes

Notes: fix exiting html fullscreen mode for embedded contents

@deepak1556
fix: HTML fullscreen request for sub frames
03b7059 
Don't re-enter fullscreen if there is a pending operation,
for subframe fullscreen request `EnterFullScreenModeForTab`
will be called for both the frame in question as well as
the outer webContents hosting it.
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jun 11, 2019
@codebytere codebytere merged commit 5e32029 into master Jun 13, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 13, 2019

Release Notes Persisted

fix exiting html fullscreen mode for embedded contents

@codebytere codebytere deleted the fix_subframe_fullscreen branch June 13, 2019 21:03
@trop
Copy link
Contributor

trop bot commented Jun 13, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Jun 13, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jun 13, 2019

I have automatically backported this PR to "6-0-x", please check out #18775

codebytere pushed a commit that referenced this pull request Jun 13, 2019
@deepak1556 @codebytere
fix: HTML fullscreen request for sub frames (#18736)
e64db94 
Don't re-enter fullscreen if there is a pending operation,
for subframe fullscreen request `EnterFullScreenModeForTab`
will be called for both the frame in question as well as
the outer webContents hosting it.
@codebytere codebytere mentioned this pull request Jun 13, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jun 13, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #18781

codebytere added a commit that referenced this pull request Jun 14, 2019
@codebytere
fix: HTML fullscreen request for sub frames (#18736) (#18781)
bf9b001 
Don't re-enter fullscreen if there is a pending operation,
for subframe fullscreen request `EnterFullScreenModeForTab`
will be called for both the frame in question as well as
the outer webContents hosting it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exiting Fullscreen mode for Embedded Content does not work.
3 participants
@deepak1556 @zcbenz @codebytere