Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw error on invalid URLs when setting cookie #18756

Merged
merged 6 commits into from Jun 14, 2019
Merged

fix: throw error on invalid URLs when setting cookie #18756

merged 6 commits into from Jun 14, 2019

Commits on Jun 12, 2019

  1. fix: Check for invalid URLs with GURL

    @erickzhao
    erickzhao committed Jun 12, 2019
    Copy the full SHA
    ed42f60 View commit details
    Browse the repository at this point in the history

  2. docs: Clarify that invalid URLs are no bueno

    @erickzhao
    erickzhao committed Jun 12, 2019
    Copy the full SHA
    ef325f6 View commit details
    Browse the repository at this point in the history

  3. test: Add test to verify that invalid URL throws

    @erickzhao
    erickzhao committed Jun 12, 2019
    Copy the full SHA
    1ce0f3d View commit details
    Browse the repository at this point in the history

  4. fix: Move variable declaration above usage

    @erickzhao
    erickzhao committed Jun 12, 2019
    Copy the full SHA
    c7239c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2019

  1. fix: is_empty -> is_valid 

    Co-Authored-By: Samuel Attard <samuel.r.attard@gmail.com>
    @erickzhao @MarshallOfSound
    erickzhao and MarshallOfSound committed Jun 13, 2019
    Copy the full SHA
    746cdc9 View commit details
    Browse the repository at this point in the history

  2. Update docs/api/cookies.md 

    Co-Authored-By: Samuel Attard <samuel.r.attard@gmail.com>
    @MarshallOfSound
    Micha Hanselmann and MarshallOfSound committed Jun 13, 2019
    Copy the full SHA
    8e45bff View commit details
    Browse the repository at this point in the history