fix: app.getAppPath() returning default-app path when no package.json found

[miniak]

Description of Change

app.getAppPath() currently returns the default-app path when running electron app with no package.json or electron app/index.js. It should return the path to app instead.

The default-app only calls app._setDefaultAppPaths(packagePath) when package.json exists.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed app.getAppPath() returning default-app path when running electron app with no package.json or electron app/index.js. Now the directory containing the executed file is returned.

[codebytere]

This test:

node feature inspector "after each" hook for "does does not crash when quitting with the inspector connected" - "after each" hook for "does does not crash when quitting with the inspector connected"

seems to be deterministically failing on both macOS and Linux atm

[zcbenz]

Marking request changes as there is a failing test that needs to be fixed.

The change itself looks good to me. I ❤️ this change as it would fix some weirdness when running test apps.

[miniak]

@zcbenz I had to implement it differently, please review again

[miniak]

@codebytere fixed, can you please check again?

[release-clerk]

Release Notes Persisted

Fixed app.getAppPath() returning default-app path when running electron app with no package.json or electron app/index.js. Now the directory containing the executed file is returned.

[trop]

I was unable to backport this PR to "3-1-x" cleanly;
you will need to perform this backport manually.

[trop]

I was unable to backport this PR to "4-2-x" cleanly;
you will need to perform this backport manually.

[trop]

I have automatically backported this PR to "5-0-x", please check out #18889

[trop]

A maintainer has manually backported this PR to "5-0-x", please check out #18894

[trop]

A maintainer has manually backported this PR to "4-2-x", please check out #18895

[trop]

A maintainer has manually backported this PR to "3-1-x", please check out #18896