feat: add contents.getOSProcessIdForFrame() #18769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/pid-for-frame
branch
from
e0c5bce
to
77b77f3
Compare
miniak
force-pushed
the
miniak/pid-for-frame
branch
from
77b77f3
to
de93733
Compare
miniak
changed the title
miniak
force-pushed
the
miniak/pid-for-frame
branch
from
de93733
to
60f5d2c
Compare
deepak1556
approved these changes
Jun 13, 2019
| const [{ frameId: frameIdMain }, pidMain] = await promise1 | ||
| const [{ frameId: frameIdFrame }, pidFrame] = await promise2 | ||
|
|
||
| expect(w.webContents.getOSProcessIdForFrame(frameIdMain)).to.equal(pidMain) |
There was a problem hiding this comment.
Can you add a check for verifying the process ids are different and the frame ids are also different between the main frame and iframe.
The reason for frame id check is that its based on routing id, which maybe unique at the moment but if chromium makes them per process identifier then we should switch to something like GlobalFrameRoutingId. This spec would help recover from such changes.
There was a problem hiding this comment.
@deepak1556 I am actually thinking about changing the API lookup by GetFrameName instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added
webContents.getOSProcessIdForFrame(). This allows getting the pid of renderers hosting cross-origin frames.Required for tests in #18650
Checklist
npm testpassesRelease Notes
Notes: Added
webContents.getOSProcessIdForFrame(). This allows getting the pid of renderers hosting cross-origin frames.