Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use is_valid for cookie url validation #18770

Merged
merged 3 commits into from Jun 14, 2019
Merged

fix: use is_valid for cookie url validation #18770

merged 3 commits into from Jun 14, 2019

Conversation

deermichel
Copy link
Contributor

Description of Change

cc @codebytere @ckerr

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 13, 2019
MarshallOfSound
MarshallOfSound reviewed Jun 13, 2019
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this absolutely detonated our tests, commenting here to X-ref from 5-0-x PR

@deermichel
Copy link
Contributor Author

Huh, that's interesting...

@deermichel
Copy link
Contributor Author

@MarshallOfSound should be fine now 😆

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 14, 2019
@codebytere codebytere merged commit 83c3f71 into master Jun 14, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 14, 2019

No Release Notes

@codebytere codebytere deleted the intern/cookies-fix branch June 14, 2019 17:56
@trop
Copy link
Contributor

trop bot commented Jun 14, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

codebytere pushed a commit that referenced this pull request Jun 17, 2019
@codebytere
fix: use is_valid for cookie url validation (#18770)
b2aa4a0 
Use is_valid instead of is_empty to validate url on cookies.set().
@codebytere codebytere mentioned this pull request Jun 17, 2019
Merged
codebytere added a commit that referenced this pull request Jun 18, 2019
@codebytere
fix: use is_valid for cookie url validation (#18770) (#18843)
eb15be0 
Use is_valid instead of is_empty to validate url on cookies.set().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@ckerr ckerr Awaiting requested review from ckerr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deermichel @codebytere @MarshallOfSound