fix: use effectiveAppearance to check dark mode on mojave and above #18845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…18666) * fix: use effectiveAppearance to check dark mode on mojave and above * chore: add forward declarations for dark appearance
miniak
approved these changes
Jun 17, 2019
codebytere
commented
Jun 17, 2019
| base::scoped_nsobject<AtomMenuController> menuController([ | ||
| [AtomMenuController alloc] initWithModel:menu_model | ||
| useDefaultAccelerator:NO]); | ||
| base::scoped_nsobject<AtomMenuController> menuController( |
There was a problem hiding this comment.
(this is just autoformatting)
|
Release Notes Persisted
|
|
I have automatically backported this PR to "5-0-x", please check out #18852 |
This was referenced Jun 17, 2019
|
I have automatically backported this PR to "4-2-x", please check out #18853 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #18666.
See that PR for more details.
Notes: Fixed issue on macOS Catalina where the tray icon would be highlighted incorrectly and sometimes invisible.