Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: roll node to fix http2 memory leak #18868

Merged
merged 1 commit into from Jun 19, 2019
Merged

Conversation

MarshallOfSound
Copy link
Member

Fixes #18817

Does what it says on the tin, was a clean cherry-pick

Notes: Backported a patch from node that fixes an http/2 memory leak:

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 18, 2019
@deepak1556 deepak1556 requested a review from a team June 18, 2019 23:03
@MarshallOfSound MarshallOfSound merged commit ae49aa4 into master Jun 19, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 19, 2019

Release Notes Persisted

Backported a patch from node that fixes an http/2 memory leak:

@trop
Copy link
Contributor

trop bot commented Jun 19, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jun 19, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jun 19, 2019

A maintainer has manually backported this PR to "6-0-x", please check out #18882

@trop
Copy link
Contributor

trop bot commented Jun 19, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #18883

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 19, 2019
@sofianguy sofianguy added this to Fixed in 5.0.6 in 5.0.x Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.6
Development

Successfully merging this pull request may close these issues.

http2 code in Electron 5/6 suffers from a known memory leak
3 participants