fix: throw error on invalid URLs when setting cookie #18911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
codebytere
requested changes
Jun 21, 2019
There was a problem hiding this comment.
@deermichel @erickzhao for the the 5-0-x backport, we needed to run through the Releases WG since it does change behavior: I'm happy to venture down that route once more but given that this wouldn't have broken many/any end users i think it may not be in our best interest to backport to 4-2-x.
|
@codebytere Sure thing. Let's shelve the PR if it isn't worth the hassle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Backport of #18756
See that PR for details.
Checklist
npm testpassesRelease Notes
Notes: Added check for invalid URLs upon setting cookies