Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement BrowserWindow.getMediaSourceId() and BrowserWindow.moveAbove(mediaSourceId) #18926

Merged
merged 2 commits into from Aug 15, 2019
Merged

feat: Implement BrowserWindow.getMediaSourceId() and BrowserWindow.moveAbove(mediaSourceId) #18926

merged 2 commits into from Aug 15, 2019

Commits on Aug 13, 2019

  1. feat: Implement BrowserWindow.getMediaSourceId 

    Return the Window id in the format of DesktopCapturerSource's id.
For example "window:1234:0".

electron#16460

Notes: Added BrowserWindow.getMediaSourceId
    Julien Isorce committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    64131e3 View commit details
    Browse the repository at this point in the history

  2. feat: Implement BrowserWindow.moveAbove(mediaSourceId) 

    BrowserWindow.{focus,blur,moveTop}() are not enough in some
situations. For example when implementing an overlay that
follows another window that can lose focus. In that case
it is useful to move the overlay above the tracked window.

sourceId is a string in the format of DesktopCapturerSource.id,
for example "window:1869:0".

Notes: Added BrowserWindow.moveAbove(mediaSourceId)

electron#18922
    Julien Isorce authored and Julien Isorce committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    9ca6bc0 View commit details
    Browse the repository at this point in the history