New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: override the timers module impls to activate the uv loop #18948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Release Notes Persisted
|
I was unable to backport this PR to "5-0-x" cleanly; |
I was unable to backport this PR to "4-2-x" cleanly; |
I have automatically backported this PR to "6-0-x", please check out #18961 |
A maintainer has manually backported this PR to "5-0-x", please check out #18965 |
Fixes #18938
Notes: Fixed issue where
require('timers').setTimeout
would sometimes never fire in the renderer process