Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct modal focus behavior on macOS #18995

Merged
merged 8 commits into from Jul 1, 2019
Merged

fix: Correct modal focus behavior on macOS #18995

merged 8 commits into from Jul 1, 2019

Commits on Jun 25, 2019

  1. wip: wish i could hack the main window focus away

    @erickzhao
    erickzhao committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    64e4b86 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. main -> key

    @erickzhao
    erickzhao committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    25096e3 View commit details
    Browse the repository at this point in the history

  2. remove useless code

    @erickzhao
    erickzhao committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    7af5802 View commit details
    Browse the repository at this point in the history

  3. test: Add focus event spec

    @erickzhao
    erickzhao committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    6d7610b View commit details
    Browse the repository at this point in the history

  4. test: more robust spec

    @erickzhao
    erickzhao committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    5d3bc09 View commit details
    Browse the repository at this point in the history

  5. test: simplify test

    @erickzhao
    erickzhao committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    9dc2fba View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. duplicate non-firing macOS event listener 😳

    @erickzhao
    erickzhao committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    84767b9 View commit details
    Browse the repository at this point in the history

  2. destroy 🚨

    @erickzhao
    erickzhao committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    19497b4 View commit details
    Browse the repository at this point in the history