fix: dark mode tray opacity on Mojave #19013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
fix-tray-transparency
branch
from
6f2b9db
to
d3ea248
Compare
|
@codebytere I assume you're not running catalina, I'd like to verify this on a catalina machine before we declare it fixed. I can test this afternoon if no one else has a catalina machine available |
codebytere
force-pushed
the
fix-tray-transparency
branch
from
d3ea248
to
d051a58
Compare
3 tasks
MarshallOfSound
added
the
fast-track 🚅
MarshallOfSound
requested changes
Jun 29, 2019
MarshallOfSound
force-pushed
the
fix-tray-transparency
branch
from
bc2dcfb
to
1037c3d
Compare
codebytere
force-pushed
the
fix-tray-transparency
branch
from
1037c3d
to
50c7885
Compare
MarshallOfSound
approved these changes
Jul 2, 2019
|
Release Notes Persisted
|
|
I have automatically backported this PR to "5-0-x", please check out #19082 |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #19009
Closes #19006.
Fixes an issue which is fixed in
masteras a result of this Chromium CL.Previously Chromium forward-declared
NSAppearanceNameDarkAquaname as anNSString*, so our updated functions in #18666 would never believe themselves to be in dark mode.This fixes that issue by removing Chromium's older forward declarations and adding them in ourselves.
cc @MarshallOfSound
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where the Tray icon would never believe itself to be in dark mode.