fix: delay emitting screen events by a tick to avoid re-entrancy crash #19016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
requested changes
Jun 27, 2019
patches/chromium/fix_modify_notifydisplayschanged_to_copy_vectors_on_call.patch
Outdated
Show resolved
Hide resolved
patches/chromium/fix_modify_notifydisplayschanged_to_copy_vectors_on_call.patch
Outdated
Show resolved
Hide resolved
|
@nornagon I tried that locally but it didn't consistently fix it, this did. I also think we can't guarantee that our code is the only thing that could trigger a re-entry. We should ensure this method can handle re-entry no matter what causes it, |
MarshallOfSound
force-pushed
the
fix-display-added-crash
branch
from
6a92d78
to
a0f3b09
Compare
MarshallOfSound
changed the title
MarshallOfSound
force-pushed
the
fix-display-added-crash
branch
from
a0f3b09
to
cd46ab6
Compare
nornagon
reviewed
Jun 27, 2019
MarshallOfSound
force-pushed
the
fix-display-added-crash
branch
from
cd46ab6
to
817a981
Compare
nornagon
reviewed
Jun 27, 2019
MarshallOfSound
force-pushed
the
fix-display-added-crash
branch
from
817a981
to
e703778
Compare
nornagon
approved these changes
Jun 27, 2019
deepak1556
reviewed
Jun 27, 2019
MarshallOfSound
force-pushed
the
fix-display-added-crash
branch
from
e703778
to
f9be919
Compare
deepak1556
approved these changes
Jun 28, 2019
|
Release Notes Persisted
|
3 tasks
|
I have automatically backported this PR to "6-0-x", please check out #19022 |
|
I have automatically backported this PR to "5-0-x", please check out #19023 |
|
I have automatically backported this PR to "4-2-x", please check out #19024 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user code created / destroyed windows inside a screen event handler it could cause re-entrancy on the
WndProchandler for screen related events causing memory corruption. If we delay the events going to user we won't re-entry and everything will be fine.Notes: Fixed crash when creating certain types of windows in the
display-*events