Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct modal focus behavior on macOS #19061

Merged
merged 9 commits into from Jul 3, 2019
Merged

fix: Correct modal focus behavior on macOS #19061

merged 9 commits into from Jul 3, 2019

Commits on Jul 1, 2019

  1. wip: wish i could hack the main window focus away

    @erickzhao
    erickzhao committed Jul 1, 2019
    Copy the full SHA
    7cb0324 View commit details
    Browse the repository at this point in the history

  2. main -> key

    @erickzhao
    erickzhao committed Jul 1, 2019
    Copy the full SHA
    7ba99ab View commit details
    Browse the repository at this point in the history

  3. remove useless code

    @erickzhao
    erickzhao committed Jul 1, 2019
    Copy the full SHA
    ed23868 View commit details
    Browse the repository at this point in the history

  4. test: Add focus event spec

    @erickzhao
    erickzhao committed Jul 1, 2019
    Copy the full SHA
    4045083 View commit details
    Browse the repository at this point in the history

  5. test: more robust spec

    @erickzhao
    erickzhao committed Jul 1, 2019
    Copy the full SHA
    f4dfb5b View commit details
    Browse the repository at this point in the history

  6. test: simplify test

    @erickzhao
    erickzhao committed Jul 1, 2019
    Copy the full SHA
    f429443 View commit details
    Browse the repository at this point in the history

  7. duplicate non-firing macOS event listener 😳

    @erickzhao
    erickzhao committed Jul 1, 2019
    Copy the full SHA
    fbc8ad2 View commit details
    Browse the repository at this point in the history

  8. destroy 🚨

    @erickzhao
    erickzhao committed Jul 1, 2019
    Copy the full SHA
    43ef566 View commit details
    Browse the repository at this point in the history

  9. chore: remove unused variable

    @erickzhao
    erickzhao committed Jul 1, 2019
    Copy the full SHA
    c567d29 View commit details
    Browse the repository at this point in the history