Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct modal focus behavior on macOS #19062

Merged
merged 8 commits into from
Jul 1, 2019
Merged

fix: Correct modal focus behavior on macOS #19062

merged 8 commits into from
Jul 1, 2019

Commits on Jul 1, 2019

  1. wip: wish i could hack the main window focus away

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    5215471 View commit details
    Browse the repository at this point in the history

  2. main -> key

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    ce9309b View commit details
    Browse the repository at this point in the history

  3. remove useless code

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    a3c6a6e View commit details
    Browse the repository at this point in the history

  4. test: Add focus event spec

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    ccebe90 View commit details
    Browse the repository at this point in the history

  5. test: more robust spec

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    233c8d4 View commit details
    Browse the repository at this point in the history

  6. test: simplify test

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    b69d95d View commit details
    Browse the repository at this point in the history

  7. duplicate non-firing macOS event listener 😳

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    5109fdd View commit details
    Browse the repository at this point in the history

  8. destroy 🚨

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    9d2af58 View commit details
    Browse the repository at this point in the history