Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct modal focus behavior on macOS #19063

Merged
merged 9 commits into from Jul 2, 2019
Merged

fix: Correct modal focus behavior on macOS #19063

merged 9 commits into from Jul 2, 2019

Commits on Jul 1, 2019

  1. wip: wish i could hack the main window focus away

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Copy the full SHA
    de09fa7 View commit details
    Browse the repository at this point in the history

  2. main -> key

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Copy the full SHA
    b4d8412 View commit details
    Browse the repository at this point in the history

  3. remove useless code

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Copy the full SHA
    e10f479 View commit details
    Browse the repository at this point in the history

  4. test: Add focus event spec

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Copy the full SHA
    e1eac86 View commit details
    Browse the repository at this point in the history

  5. test: more robust spec

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Copy the full SHA
    d587a8d View commit details
    Browse the repository at this point in the history

  6. test: simplify test

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Copy the full SHA
    cba4985 View commit details
    Browse the repository at this point in the history

  7. duplicate non-firing macOS event listener 😳

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Copy the full SHA
    f677e20 View commit details
    Browse the repository at this point in the history

  8. destroy 🚨

    @erickzhao @electron-bot
    erickzhao authored and electron-bot committed Jul 1, 2019
    Copy the full SHA
    66d7d46 View commit details
    Browse the repository at this point in the history

  9. chore: remove unused variable

    @erickzhao
    erickzhao committed Jul 1, 2019
    Copy the full SHA
    fb41fa2 View commit details
    Browse the repository at this point in the history