Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use binding.ipc instead of binding.sendTo which is undefined #19103

Merged
merged 1 commit into from
Jul 3, 2019
Merged

fix: use binding.ipc instead of binding.sendTo which is undefined #19103

merged 1 commit into from
Jul 3, 2019

Conversation

MarshallOfSound
Copy link
Member

Found while investigating #19070. binding.sendTo is not a thing, binding.ipc.sendTo, that's a thing 馃槃

Notes: Fixed some chrome extension communication (MessagePort.postMessage) not working

@electron-cation electron-cation bot added the new-pr 馃尡 PR opened in the last 24 hours label Jul 3, 2019
@MarshallOfSound MarshallOfSound changed the title fix: use bidning.ipc instead of binding.sendTo which is undefined fix: use binding.ipc instead of binding.sendTo which is undefined Jul 3, 2019
nornagon
nornagon approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, wild that this took so long to get noticed. we should add tests that hit this path.

@MarshallOfSound MarshallOfSound merged commit 5a1b661 into master Jul 3, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 3, 2019

Release Notes Persisted

Fixed some chrome extension communication (MessagePort.postMessage) not working

@MarshallOfSound MarshallOfSound deleted the fix-internal-ipc-send branch July 3, 2019 23:36
@trop trop bot mentioned this pull request Jul 3, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jul 3, 2019

I have automatically backported this PR to "6-0-x", please check out #19106

@electron-cation electron-cation bot removed the new-pr 馃尡 PR opened in the last 24 hours label Jul 10, 2019
@trop trop bot added the merged/6-0-x label Jul 10, 2019
@sofianguy sofianguy added this to Fixed in 6.0.0-beta.13 in 6.1.x Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
6.1.x
Fixed in 6.0.0-beta.13
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarshallOfSound @nornagon