fix: serialize messages being sent over chrome message ports #19104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
approved these changes
Jul 15, 2019
|
Release Notes Persisted
|
|
I was unable to backport this PR to "5-0-x" cleanly; |
|
I have automatically backported this PR to "6-0-x", please check out #19252 |
|
@MarshallOfSound do we want to send this back to |
|
A maintainer has manually backported this PR to "5-0-x", please check out #19654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome appears to serialize these messages (see #19070) so we should as well to be consistent and to avoid bugs with Uint8/16 arrays
Fixes #19070
Notes:
Uint8ArrayandUint16Arraycan now be sent correctly in Chrome ExtensionMessagePortinstances