refactor: implement GetResourcesPath using MainApplicationBundlePath on Mac #19135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/resources-path
branch
from
2bc45f5
to
38c3c56
Compare
alexeykuzmin
approved these changes
Jul 8, 2019
codebytere
approved these changes
Jul 9, 2019
|
No Release Notes |
nornagon
reviewed
Jul 9, 2019
| @class NSBundle; | ||
| #else | ||
| struct NSBundle; |
There was a problem hiding this comment.
This is super weird, why do we need to define NSBundle in non-objc code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Re-use existing logic in
MainApplicationBundlePathto avoid duplicating similar code.Also remove leftover
NodeBindings::GetHelperResourcesPath()after #15701.Checklist
npm testpassesRelease Notes
Notes: no-notes