Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification #19159

Merged
merged 50 commits into from
Apr 1, 2021
Merged

feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification #19159

merged 50 commits into from
Apr 1, 2021

Commits on Dec 18, 2020

  1. feat: Use GtkFileChooserNative if available to support XDG portals 

    With this commit, users on KDE/plasma will finally have support in
Electron for their native file choosers dialogs.
    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    7018d60 View commit details
    Browse the repository at this point in the history

  2. fix: namespace

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    43b6de1 View commit details
    Browse the repository at this point in the history

  3. fix: labels were reversed

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    cad379b View commit details
    Browse the repository at this point in the history

  4. fix: lint issue

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    d192d26 View commit details
    Browse the repository at this point in the history

  5. fix: clean up some implementation

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    fbbc100 View commit details
    Browse the repository at this point in the history

  6. fix: remove deprecation branch

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    5e06ecc View commit details
    Browse the repository at this point in the history

  7. fix: remove unused header

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    c09eb5d View commit details
    Browse the repository at this point in the history

  8. fix: remove unused gi18n.h include 

    Not sure why this is
    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    6584d8e View commit details
    Browse the repository at this point in the history

  9. fix: add the set_data call into the mirrored SetGtkTransientForAura func

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    22a0d76 View commit details
    Browse the repository at this point in the history

  10. fix: remove gmodule support and use native for the dialog regardless

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    ce211f6 View commit details
    Browse the repository at this point in the history

  11. fix: undo yarn.lock changes

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    e938c06 View commit details
    Browse the repository at this point in the history

  12. fix: lint

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    26e2caa View commit details
    Browse the repository at this point in the history

  13. fix: remove x11 unncessary x11 include

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    b46f9a0 View commit details
    Browse the repository at this point in the history

  14. fix: lint

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    a60c7d3 View commit details
    Browse the repository at this point in the history

  15. fix: remove SetGtkTransientForAura

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    e3b9b83 View commit details
    Browse the repository at this point in the history

  16. Revert "fix: remove gmodule support and use native for the dialog reg… 

    …ardless"

This reverts commit 062db59.
    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    309f1a7 View commit details
    Browse the repository at this point in the history

  17. fix: add support in a backwards compatible way 

    Use GModule to dynamically load functions from libgtk in order to
support GtkNativeDialog.
    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    29b0f2b View commit details
    Browse the repository at this point in the history

  18. fix: lint

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    d70f84e View commit details
    Browse the repository at this point in the history

  19. docs: update comment

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    22151f6 View commit details
    Browse the repository at this point in the history

  20. Revert "fix: remove x11 unncessary x11 include" 

    This reverts commit 589cff5.
    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    301e4b3 View commit details
    Browse the repository at this point in the history

  21. fix: compiler errors

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    fef6ac3 View commit details
    Browse the repository at this point in the history

  22. fix: int -> x11::time

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    80aeb99 View commit details
    Browse the repository at this point in the history

  23. fix: move GtkNativeDialog static data to global state

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    cf779fa View commit details
    Browse the repository at this point in the history

  24. fix: revert yarn.lock change

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    8b482e1 View commit details
    Browse the repository at this point in the history

  25. update: for code review comments

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    47a15d5 View commit details
    Browse the repository at this point in the history

  26. fix: remove functional header

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    da52c8b View commit details
    Browse the repository at this point in the history

  27. fix: variable name

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    e0668a3 View commit details
    Browse the repository at this point in the history

  28. fix: rename GTK native initalization func

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    a6490d8 View commit details
    Browse the repository at this point in the history

  29. Help out the compiler

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    116232c View commit details
    Browse the repository at this point in the history

  30. Help out the compiler

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    013d052 View commit details
    Browse the repository at this point in the history

  31. Help out the compiler

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    9035eb3 View commit details
    Browse the repository at this point in the history

  32. Fix function signature

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    039e1e7 View commit details
    Browse the repository at this point in the history

  33. Remove unused header

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    4c1c674 View commit details
    Browse the repository at this point in the history

  34. Rename optional boolean for GtkFileChooserNative support

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    187b207 View commit details
    Browse the repository at this point in the history

  35. Add back in USE_X11 check

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    e4229a1 View commit details
    Browse the repository at this point in the history

  36. Satisfy linter

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    79b5aa6 View commit details
    Browse the repository at this point in the history

  37. Resatisfy linter

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    55ec914 View commit details
    Browse the repository at this point in the history

  38. Fix alignment of if

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    bbd2609 View commit details
    Browse the repository at this point in the history

  39. Fix alignment of arguments

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    d991097 View commit details
    Browse the repository at this point in the history

  40. linting...

    @tristan957
    tristan957 committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    9e2d7e0 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. fix: add back in the i18n hack

    @tristan957
    tristan957 committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    1c8b384 View commit details
    Browse the repository at this point in the history

  2. fix: lint

    @tristan957
    tristan957 committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    0e70859 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. Respond to some review comments

    @tristan957
    tristan957 committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    20bfff4 View commit details
    Browse the repository at this point in the history

  2. fix: lint

    @tristan957
    tristan957 committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    9b0aa96 View commit details
    Browse the repository at this point in the history

  3. Make adding filter agnostic

    @tristan957
    tristan957 committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    02a07e3 View commit details
    Browse the repository at this point in the history

  4. fix: transform is in place

    @tristan957
    tristan957 committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    ce5f94a View commit details
    Browse the repository at this point in the history

  5. fix: remove std::transform because not c++17

    @tristan957
    tristan957 committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    b4221c7 View commit details
    Browse the repository at this point in the history

  6. Remove unused include

    @tristan957
    tristan957 committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    b4aba74 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. fix: address Cheng's review

    @tristan957
    tristan957 committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    2d4f82e View commit details
    Browse the repository at this point in the history

  2. fix: Remove unused header

    @tristan957
    tristan957 committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    25b5401 View commit details
    Browse the repository at this point in the history