Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move some BrowserWindow specs to the main process #19182

Merged
merged 20 commits into from Jul 16, 2019
Merged

test: move some BrowserWindow specs to the main process #19182

merged 20 commits into from Jul 16, 2019

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Jul 9, 2019 •
edited

Description of Change

Moved the webPreferences specs.

Checklist

Release Notes

Notes: none

zcbenz
zcbenz reviewed Jul 11, 2019
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Windows failing tests do not seem to be flaky, both x86 and x64 CI fail at same tests.

@codebytere codebytere merged commit 27599a8 into master Jul 16, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 16, 2019

No Release Notes

@codebytere codebytere deleted the move-browser-window-specs branch July 16, 2019 04:13
@miniak
Copy link
Contributor

miniak commented Jul 16, 2019

@nornagon seems like the test that I've added recently in #19198 was lost

nornagon added a commit that referenced this pull request Jul 16, 2019
@nornagon
test: re-add accidentally deleted test
ad1c919 
this was lost due to a tragic merge incident in #19182
@nornagon nornagon mentioned this pull request Jul 16, 2019
Merged
6 tasks
MarshallOfSound pushed a commit that referenced this pull request Jul 16, 2019
@nornagon @MarshallOfSound
test: re-add accidentally deleted test (#19282)
42f283c 
this was lost due to a tragic merge incident in #19182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nornagon @miniak @zcbenz @codebytere