Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: implement isRemoteModuleEnabled via getLastWebPreferences() #19220

Merged
merged 1 commit into from Aug 28, 2019
Merged

refactor: implement isRemoteModuleEnabled via getLastWebPreferences() #19220

merged 1 commit into from Aug 28, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jul 12, 2019 •
edited

Description of Change

Now that getLastWebPreferences() was fixed by #19198, we can use it to determine whether the remote module is enabled instead of exposing a custom _isRemoteModuleEnabled() method.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak added the wip ⚒ label Jul 12, 2019
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jul 12, 2019
@miniak miniak force-pushed the miniak/is-remote-module-enabled branch from 925b131 to 5b82857 Compare August 19, 2019 12:01
@miniak miniak removed the wip ⚒ label Aug 19, 2019
@miniak miniak self-assigned this Aug 19, 2019
@miniak miniak marked this pull request as ready for review August 19, 2019 15:40
@miniak miniak force-pushed the miniak/is-remote-module-enabled branch 3 times, most recently from 4a20069 to f3ad6d2 Compare August 19, 2019 15:47
@miniak miniak added the wip ⚒ label Aug 19, 2019
@miniak miniak force-pushed the miniak/is-remote-module-enabled branch from 07c79ee to c601f50 Compare August 19, 2019 17:04
@miniak miniak removed the wip ⚒ label Aug 20, 2019
@miniak
Copy link
Contributor Author

miniak commented Aug 24, 2019

@nornagon can you please review?

@miniak miniak mentioned this pull request Aug 26, 2019
Merged
4 tasks
nornagon
nornagon reviewed Aug 26, 2019
View reviewed changes
lib/browser/rpc-server.js Outdated Show resolved Hide resolved
shell/browser/web_contents_preferences.cc Outdated Show resolved Hide resolved
@miniak miniak force-pushed the miniak/is-remote-module-enabled branch from c601f50 to 3c5c342 Compare August 26, 2019 20:39
@miniak miniak force-pushed the miniak/is-remote-module-enabled branch from 3c5c342 to 9e53610 Compare August 26, 2019 20:41
@miniak miniak requested a review from nornagon August 26, 2019 20:41
@miniak
Copy link
Contributor Author

miniak commented Aug 27, 2019

@nornagon should be ready to go

@nornagon nornagon merged commit 01fdb80 into master Aug 28, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 28, 2019

No Release Notes

@nornagon nornagon deleted the miniak/is-remote-module-enabled branch August 28, 2019 22:57
@miniak miniak mentioned this pull request Sep 30, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @nornagon @zcbenz