Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate webRequest module to NetworkService (Part 2) #19338

Merged
merged 6 commits into from Jul 22, 2019

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Jul 19, 2019

Description of Change

Refs #15791.

This PR implements InProgressRequest, which can hijack URL loader requests and provide hooks for events. The code is referenced from extensions::WebRequestProxyingURLLoaderFactory.

Note that currently InProgressRequest is not being used, and existing behaviors are not affected. The migration will be done with following steps:

  1. implement the JS webRequest APIs;
  2. connect JS webRequest APIs to InProgressRequest;
  3. actually hijack the URL loader requests with InProgressRequest.

Checklist

Release Notes

Notes: no-notes

@zcbenz zcbenz requested a review from deepak1556 July 19, 2019 08:33
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jul 19, 2019
@deepak1556 deepak1556 merged commit eb6660f into master Jul 22, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 22, 2019

No Release Notes

@deepak1556 deepak1556 deleted the webrequest-networkservice-2 branch July 22, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants