Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash reporting on Windows on Arm #19391

Merged
merged 8 commits into from Aug 27, 2019
Merged

fix: crash reporting on Windows on Arm #19391

merged 8 commits into from Aug 27, 2019

Commits on Aug 26, 2019

  1. feat: cherry-pick V8 unwinding support 

    This commit backports [1] (originally written by @ThomsonTan) into V8
7.6. With this patch in place, calls made from JS into the atom core
which crash electron.exe will now generate crash dumps on Windows on
Arm rather than silently dying.

[1] https://chromium-review.googlesource.com/c/v8/v8/+/1701133/11
    @richard-townsend-arm
    richard-townsend-arm committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    57621d0 View commit details
    Browse the repository at this point in the history

  2. feat: backport crashpad cpu capture context 

    Backport of [1] (originally written by @kaadam) to Chromium 76's
crashpad. This lets you see the register values within the crash dump.

[1]
https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1632749
    @richard-townsend-arm
    richard-townsend-arm committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    01ad734 View commit details
    Browse the repository at this point in the history

  3. build: make win on arm patches only apply for win on arm builds

    @MarshallOfSound @richard-townsend-arm
    MarshallOfSound authored and richard-townsend-arm committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    a2b8d73 View commit details
    Browse the repository at this point in the history

  4. Update .patches

    @MarshallOfSound @richard-townsend-arm
    MarshallOfSound authored and richard-townsend-arm committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    c312814 View commit details
    Browse the repository at this point in the history

  5. Update .patches

    @MarshallOfSound @richard-townsend-arm
    MarshallOfSound authored and richard-townsend-arm committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    02cfc0c View commit details
    Browse the repository at this point in the history

  6. Update DEPS

    @MarshallOfSound @richard-townsend-arm
    MarshallOfSound authored and richard-townsend-arm committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    2a3dac2 View commit details
    Browse the repository at this point in the history

  7. fix: update the patch to the as-landed version

    @richard-townsend-arm
    richard-townsend-arm committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    54fdc5d View commit details
    Browse the repository at this point in the history

  8. fix: remove accidental revert of crashpad_pid_check.patch

    @richard-townsend-arm
    richard-townsend-arm committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    3a1b8e7 View commit details
    Browse the repository at this point in the history