Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix TouchBar related documentation #19444

Merged
merged 1 commit into from Aug 1, 2019
Merged

docs: fix TouchBar related documentation #19444

merged 1 commit into from Aug 1, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jul 24, 2019 •
edited

Description of Change

  • Fixed optionality according to the actual behavior in the code
  • Added missing list of values for string based enums
  • Added references to macOS SDK constants
  • Replaced null with none in selectedStyle and overlayStyle as they have the same behavior, but none works better with the enum

Checklist

Release Notes

Notes: Fixed bunch of issues in the documentation for TouchBar related APIs.

@miniak miniak added the wip ⚒ label Jul 24, 2019
@miniak miniak self-assigned this Jul 24, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 24, 2019
@miniak miniak force-pushed the miniak/docs-touchbar branch 5 times, most recently from 384fe28 to 18bf31f Compare July 24, 2019 23:12
@nornagon
Copy link
Member

Related: #19413

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 25, 2019
@miniak miniak marked this pull request as ready for review July 31, 2019 17:33
@miniak miniak removed the wip ⚒ label Jul 31, 2019
codebytere
codebytere approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the archaeologist side 👍

@jkleinsc jkleinsc merged commit 115b576 into master Aug 1, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 1, 2019

Release Notes Persisted

Fixed bunch of issues in the documentation for TouchBar related APIs.

@jkleinsc jkleinsc deleted the miniak/docs-touchbar branch August 1, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @nornagon @jkleinsc @codebytere