Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tray.focus() #19548

Merged
merged 1 commit into from Aug 9, 2019
Merged

feat: add tray.focus() #19548

merged 1 commit into from Aug 9, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jul 31, 2019 •
edited

Description of Change

Expose NIM_SETFOCUS

Returns focus to the taskbar notification area. Notification area icons should use this message when they have completed their UI operation. For example, if the icon displays a shortcut menu, but the user presses ESC to cancel it, use tray.focus() to return focus to the notification area.

Checklist

Release Notes

Notes: Added tray.focus(), which returns focus to the taskbar notification area.

@miniak miniak self-assigned this Jul 31, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 31, 2019
@miniak miniak force-pushed the miniak/tray-focus branch 2 times, most recently from 9743eb5 to 6dfba28 Compare July 31, 2019 17:11
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 1, 2019
zcbenz
zcbenz requested changes Aug 5, 2019
View reviewed changes
shell/browser/ui/win/notify_icon.h Outdated Show resolved Hide resolved
@miniak miniak force-pushed the miniak/tray-focus branch 2 times, most recently from 5704c97 to 667f4d5 Compare August 5, 2019 17:44
@miniak miniak requested a review from zcbenz August 5, 2019 17:44
@zcbenz
Copy link
Member

zcbenz commented Aug 6, 2019

It seems that the CI on master branch is failing and this PR is affected.

@codebytere codebytere merged commit 03debb4 into master Aug 9, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 9, 2019

Release Notes Persisted

Added tray.focus(), which returns focus to the taskbar notification area.

@codebytere codebytere deleted the miniak/tray-focus branch August 9, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere Awaiting requested review from codebytere

@deermichel deermichel Awaiting requested review from deermichel

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @zcbenz @alexeykuzmin @codebytere