Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable 'reopen windows?' dialog after crash #19584

Merged
merged 1 commit into from Aug 3, 2019

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Aug 1, 2019

Description of Change

Hopefully this will stop the dialog that blocks Electron from launching after it crashed and also doesn't do anything.

Checklist

Release Notes

Notes: Prevented 'Reopen windows?' dialog from appearing on macOS after a crash.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 1, 2019
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 👍

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 2, 2019
@nornagon nornagon merged commit bd28b87 into master Aug 3, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 3, 2019

Release Notes Persisted

Prevented 'Reopen windows?' dialog from appearing on macOS after a crash.

@nornagon nornagon deleted the no-reopen-windows-dialog branch August 3, 2019 00:04
@electron electron deleted a comment Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants