Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle edge behavior for about panel on Linux #19635

Merged
merged 1 commit into from Aug 6, 2019

Conversation

erickzhao
Copy link
Member

Description of Change

Backport of #19586.

Since the first part of the PR was not relevant (bug not present in 6-0-x), I only fixed the second part:

Upon closing the About dialog, there were previously warnings from GTK stemming from the g_clear_object(&dialog) call.
This has now been replaced with a call to destroy the GtkWidget after closing the About dialog.

Since it is only advanced logging that catches this error, there are no-notes associated with this backport.

See that PR for details.

Release Notes

Notes: no-notes

@erickzhao erickzhao added backport This is a backport PR 6-0-x labels Aug 5, 2019
@codebytere codebytere merged commit 6c0157a into 6-0-x Aug 6, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 6, 2019

No Release Notes

@codebytere codebytere deleted the bp/6-0-x/about-panel-linux branch August 6, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants