Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid losing focus on inputs when opening menu (Windows/Linux) #19657

Merged
merged 2 commits into from Aug 9, 2019

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Aug 6, 2019

Description of Change

Fixes #18745.

Removes a call to give focus to the menu bar upon clicking an item, which was introduced in #15302 to improve menu bar a11y.

cc @brenca @javan

Checklist

Release Notes

Notes: Fixed bug where inputs would lose focus when opening the menu bar, preventing many menu items (Edit/Copy/Paste/etc.) to be unusable on Windows and Linux.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 6, 2019
@ckerr
Copy link
Member

ckerr commented Aug 7, 2019

This WfM on Ubuntu 19.04, testing with Javan's fiddle.

@erickzhao erickzhao changed the title [WIP] fix: avoid losing focus on inputs when opening menu (Windows/Linux) fix: avoid losing focus on inputs when opening menu (Windows/Linux) Aug 7, 2019
@erickzhao
Copy link
Member Author

@brenca Let me know if removing this LoC will cause a regression regarding your previous PR. I tested it locally and noticed no difference, but I don't have a lot of context regarding Windows a11y.

@erickzhao erickzhao marked this pull request as ready for review August 7, 2019 21:38
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 7, 2019
@codebytere codebytere self-requested a review August 8, 2019 03:04
@codebytere codebytere added target/5-0-x semver/patch backwards-compatible bug fixes and removed target/5-0-x labels Aug 8, 2019
Copy link
Contributor

@brenca brenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like to check the backports to ensure that a11y functionality doesn't suffer because of that LOC removal there.

@codebytere codebytere merged commit 1749af9 into master Aug 9, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 9, 2019

Release Notes Persisted

Fixed bug where inputs would lose focus when opening the menu bar, preventing many menu items (Edit/Copy/Paste/etc.) to be unusable on Windows and Linux.

@trop
Copy link
Contributor

trop bot commented Aug 9, 2019

I have automatically backported this PR to "7-0-x", please check out #19706

@trop trop bot removed the target/7-0-x label Aug 9, 2019
@trop
Copy link
Contributor

trop bot commented Aug 9, 2019

I have automatically backported this PR to "5-0-x", please check out #19707

@trop
Copy link
Contributor

trop bot commented Aug 9, 2019

I have automatically backported this PR to "6-0-x", please check out #19708

@javan
Copy link
Contributor

javan commented Aug 20, 2019

This WfM on Ubuntu 19.04

This change didn't fix the issue on Windows (see #18745 (comment) for details). Was it only tested on Linux?

@sofianguy sofianguy added this to 6.0.3 in 6.1.x Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
No open projects
6.1.x
6.0.3
7.2.x
Fixed in 7.0.0-beta.3
Development

Successfully merging this pull request may close these issues.

Undo/Redo/Cut/Copy/Paste & more Not work using Menubar in Windows
5 participants