New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid losing focus on inputs when opening menu (Windows/Linux) #19657
Conversation
This WfM on Ubuntu 19.04, testing with Javan's fiddle. |
f526b48
to
d99290d
Compare
@brenca Let me know if removing this LoC will cause a regression regarding your previous PR. I tested it locally and noticed no difference, but I don't have a lot of context regarding Windows a11y. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like to check the backports to ensure that a11y functionality doesn't suffer because of that LOC removal there.
Release Notes Persisted
|
I have automatically backported this PR to "7-0-x", please check out #19706 |
I have automatically backported this PR to "5-0-x", please check out #19707 |
I have automatically backported this PR to "6-0-x", please check out #19708 |
This change didn't fix the issue on Windows (see #18745 (comment) for details). Was it only tested on Linux? |
Description of Change
Fixes #18745.
Removes a call to give focus to the menu bar upon clicking an item, which was introduced in #15302 to improve menu bar a11y.
cc @brenca @javan
Checklist
npm test
passesRelease Notes
Notes: Fixed bug where inputs would lose focus when opening the menu bar, preventing many menu items (Edit/Copy/Paste/etc.) to be unusable on Windows and Linux.