Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash on print cancellation and silent print settings #19668

Merged
merged 3 commits into from Aug 7, 2019
Merged

fix: crash on print cancellation and silent print settings #19668

merged 3 commits into from Aug 7, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 7, 2019

Backport of #19598

See that PR for details.

Notes: Fixed a crash on manual print cancellation as well as an issue with deviceName not working.

@trop trop bot requested a review from a team as a code owner August 7, 2019 14:47
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 7, 2019
@trop trop bot mentioned this pull request Aug 7, 2019
Merged
6 tasks
@trop trop bot added 7-0-x backport This is a backport PR labels Aug 7, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 7, 2019
codebytere
codebytere approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending green ci

@codebytere codebytere merged commit ea9cfc1 into 7-0-x Aug 7, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 7, 2019

Release Notes Persisted

Fixed a crash on manual print cancellation as well as an issue with deviceName not working.

@codebytere codebytere deleted the trop/7-0-x-bp-fix-crash-on-print-cancellation-and-silent-print-settings-1565189263561 branch August 7, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
7-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @codebytere