Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize behavior of win.setOpacity() for invalid number values across operating systems #19673

Merged
merged 1 commit into from Aug 7, 2019

Commits on Aug 7, 2019

  1. fix: normalize behavior of win.setOpacity() for invalid number valu…

    …es across operating systems (#19535)
    
    * fix: define behavior for out-of-bounds setOpacity
    
    * fix linux issue
    
    * fix getOpacity behaviour
    
    * wrong variable
    
    * normalize more stuff
    
    * docs
    
    * test: use ifdescribe helper
    
    * Update spec-main/api-browser-window-spec.ts
    
    Co-Authored-By: Charles Kerr <ckerr@github.com>
    
    * fixes
    
    * more tests!!!
    
    * Update shell/browser/native_window_views.cc
    
    Co-Authored-By: Charles Kerr <ckerr@github.com>
    
    * Update shell/browser/native_window_mac.mm
    
    Co-Authored-By: Charles Kerr <ckerr@github.com>
    erickzhao and ckerr committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    a8a0987 View commit details
    Browse the repository at this point in the history