Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash on window.print() #19678

Merged
merged 1 commit into from Aug 8, 2019
Merged

fix: crash on window.print() #19678

merged 1 commit into from Aug 8, 2019

Conversation

codebytere
Copy link
Member

Backport of #19601.

See that PR for more details.

Notes: Fixed a crash in window.print().

@codebytere codebytere added backport This is a backport PR 5-0-x labels Aug 7, 2019
@codebytere codebytere requested a review from a team as a code owner August 7, 2019 23:17
@trop trop bot mentioned this pull request Aug 7, 2019
Merged
4 tasks
@codebytere codebytere requested a review from a team August 7, 2019 23:18
@codebytere codebytere merged commit 3fdfa68 into 5-0-x Aug 8, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 8, 2019

Release Notes Persisted

Fixed a crash in window.print().

@codebytere codebytere deleted the window-print-fix-5 branch August 8, 2019 14:52
@misbeliever
Copy link

When the device name specified as parameter, still doesn't work for me.
Checked v5, v6 and v7 after window.print() release, only v7 works with deviceName specified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @misbeliever @jkleinsc