docs: MessageBoxOptions.icon should allow type string

[jpmn]

Description of Change

In the dialog documentation (and the generated typings in electron.d.ts), it is mentionned that the icon property only supports NativeImage, but the nativeImage documentation says that:

In Electron, for the APIs that take images, you can pass either file paths or NativeImage

This PR adds support for the type string through a change in the documentation to match BrowserWindowConstructorOptions.icon?: (NativeImage) | (string); from electron.d.ts. This change should result in MessageBoxOptions.icon?: NativeImage; becoming MessageBoxOptions.icon?: (NativeImage) | (string);

Related documentation:
https://electronjs.org/docs/api/dialog#dialogshowmessageboxbrowserwindow-options
https://electronjs.org/docs/api/browser-window#new-browserwindowoptions
https://electronjs.org/docs/api/native-image#nativeimage

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation is changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Allowed string as type on MessageBoxOptions.icon to support file paths as mentioned in NativeImage documentation

[welcome]

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[deermichel]

I guess that's not the only occurrence that should be changed in our docs - but let's start somewhere. Thank you for your contribution 🎉

[jpmn]

Thank you! Is there any chance that it can be backported to 5.0.x?

[codebytere]

@jpmn yes!

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[release-clerk]

Release Notes Persisted

Allowed string as type on MessageBoxOptions.icon to support file paths as mentioned in NativeImage documentation

[trop]

I have automatically backported this PR to "5-0-x", please check out #19796

[trop]

I have automatically backported this PR to "7-0-x", please check out #19797

[trop]

I have automatically backported this PR to "6-0-x", please check out #19798