docs: add more fiddles for launch in fiddle feature
#19849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
Co-Authored-By: Samuel Attard <samuel.r.attard@gmail.com>
Co-Authored-By: Samuel Attard <samuel.r.attard@gmail.com>
codebytere
requested review from
MarshallOfSound,
ckerr,
codebytere and
deermichel
ckerr
reviewed
Aug 21, 2019
deermichel
suggested changes
Aug 21, 2019
Co-Authored-By: Charles Kerr <ckerr@github.com>
Co-Authored-By: Charles Kerr <ckerr@github.com>
ckerr
reviewed
Aug 23, 2019
|
@deermichel Can you take another look of this PR? |
|
Yes, I'll do that tmw 👍 |
deermichel
suggested changes
Aug 30, 2019
| }); | ||
|
|
||
| // and load the index.html of the app. | ||
| mainWindow.loadFile('index.html'); |
There was a problem hiding this comment.
hmm there is no index.html in this fiddle - we can remove this line or add a simple html
| y: externalDisplay.bounds.y + 50 | ||
| }) | ||
| win.loadURL('https://electronjs.org') | ||
| } |
There was a problem hiding this comment.
how about an else case with a console.log("no ext display or so")?
| // Adding a global shortcut to electron | ||
| // | ||
| // For more info, see: | ||
| // https://electronjs.org/docs/api/screen |
There was a problem hiding this comment.
should point to the global shortcut docs :)
|
@cvaldez98 Can you address the review above? |
|
I'm closing this PR since there has been no activity for a long time, please let me know if you still want to work on this and I'll reopen this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add in more fiddles to demonstrate the
screenandacceleratormodule.This is adding more code examples that can have the
Launch in Fiddlefeat on electronjs.org .The code examples are slightly modified to help the user out, but I'm open to changes of course.
Follow up from #19759
Notes: none
cc @MarshallOfSound @codebytere @ckerr @deermichel