Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notify views of contentView size change #19878

Merged
merged 1 commit into from Aug 22, 2019

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Aug 22, 2019

Description of Change

When geometry of contentView is changed the views UI of Chromium should be notified to update the UI, otherwise the UI would be displayed in wrong offset.

Currently this situation only happens when using native tab on macOS.

Close #19875.

Checklist

Release Notes

Notes: Fix web page displayed with offset when using native tab on macOS.

@trop
Copy link
Contributor

trop bot commented Aug 22, 2019

A maintainer has manually backported this PR to "4-2-x", please check out #19881

@trop
Copy link
Contributor

trop bot commented Aug 22, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #19882

@trop
Copy link
Contributor

trop bot commented Aug 22, 2019

A maintainer has manually backported this PR to "6-0-x", please check out #19888

Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@deepak1556 deepak1556 merged commit ab0bf6d into master Aug 22, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 22, 2019

Release Notes Persisted

Fix web page displayed with offset when using native tab on macOS.

@deepak1556 deepak1556 deleted the nswindow-sync-bridge-view branch August 22, 2019 21:17
@trop
Copy link
Contributor

trop bot commented Aug 22, 2019

I have automatically backported this PR to "7-0-x", please check out #19898

@trop trop bot removed the in-flight/6-0-x label Aug 23, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 23, 2019
@trop trop bot added the merged/6-0-x label Aug 23, 2019
@sofianguy sofianguy added this to Fixed in 6.0.4 in 6.1.x Aug 26, 2019
@sofianguy sofianguy added this to Fixed in 7.0.0-beta.4 in 7.2.x Sep 3, 2019
@sofianguy sofianguy added this to Fixed in 5.0.11 in 5.0.x Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.11
6.1.x
Fixed in 6.0.4
7.2.x
Fixed in 7.0.0-beta.4
Development

Successfully merging this pull request may close these issues.

Clipped view with MacOS native tabs
2 participants