fix: i18n of gtk msgbox buttons #19904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Aug 23, 2019
MarshallOfSound
approved these changes
Aug 25, 2019
rename from `gtk_util.[cc,h]` to `util_gtk.[cc,h]` so that it gets picked up by the `extra_source_filters` rule in `BUILD.gn`.
It really shows that I cannot build locally atm... :P
zcbenz
approved these changes
Aug 27, 2019
codebytere
approved these changes
Aug 27, 2019
|
Release Notes Persisted
|
|
I was unable to backport this PR to "5-0-x" cleanly; |
|
I was unable to backport this PR to "6-0-x" cleanly; |
|
I have automatically backported this PR to "7-0-x", please check out #19982 |
|
@ckerr could you please backport these to 6/5 when you have a moment? |
ckerr
added a commit
that referenced
this pull request
Aug 28, 2019
Manually backport #19904. See that PR for details.
|
A maintainer has manually backported this PR to "6-0-x", please check out #20007 |
ckerr
added a commit
that referenced
this pull request
Aug 28, 2019
Manually backport #19904. See that PR for details.
|
A maintainer has manually backported this PR to "5-0-x", please check out #20010 |
zcbenz
pushed a commit
that referenced
this pull request
Aug 29, 2019
* fix: i18n of gtk msgbox buttons Manually backport #19904. See that PR for details. * fix: make linter happy * fix: make linter happy
zcbenz
pushed a commit
that referenced
this pull request
Aug 29, 2019
* fix: i18n of gtk msgbox buttons Manually backport #19904. See that PR for details. * fix: make linter happy * fix: make linter happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Does for GTK messageboxes what #19756 (12df0e8) did for GTK file dialogs: fixes the i18n of the stock buttons in a way that doesn't break the buttons' keyboard shortcuts.
CC @codebytere
Checklist
npm testpassesRelease Notes
Notes: Fixed i18n of GTK messageboxes' stock buttons.