Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate webRequest module to NetworkService (part 3) #19968

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 27, 2019

Backport of #19648

See that PR for details.

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 27, 2019
@trop trop bot added 7-0-x backport This is a backport PR labels Aug 27, 2019
@zcbenz
Copy link
Member

zcbenz commented Aug 27, 2019

I'm backporting other webRequest PRs by hand in a batch, since they rely on each other and there are conflicts that need to be resolved.

Edit: Just saw there is already work on that: 7-0-x...nw_backport_webreq_7_x.

@deepak1556
Copy link
Member

closing in favor of #19979

@deepak1556 deepak1556 closed this Aug 27, 2019
@deepak1556 deepak1556 deleted the trop/7-0-x-bp-feat-migrate-webrequest-module-to-networkservice-part-3--1566864467230 branch August 27, 2019 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-0-x backport This is a backport PR new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants