Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable flaky remote-debugging-port test #19987

Closed
wants to merge 1 commit into from

Conversation

nornagon
Copy link
Member

Ref #19422

Notes: none

@codebytere
Copy link
Member

@nornagon this may be fixed by #19986, let's wait on that a bit?

@nornagon
Copy link
Member Author

hm, i'm not sure how #19986 could be related but i'm game to wait for a bit.

@codebytere
Copy link
Member

@nornagon could we instead try to allow this to fail and rerun? this.retries(x) where x is a number allows the test to auto-rerun x times before reporting a failure 🤔

@nornagon
Copy link
Member Author

i hate that pattern and i would rather either disable the test or actually fix it :)

@jkleinsc
Copy link
Contributor

I see in #19986 that the linux tests passed. I am rerunning them to see if they flake:
https://circleci.com/gh/electron/electron/316317
https://circleci.com/gh/electron/electron/316316

@jkleinsc
Copy link
Contributor

On rerun those tests don't flake with #19986, so can we close this PR? @nornagon what do you think?

@ckerr
Copy link
Member

ckerr commented Aug 29, 2019

I'm not sure why this flake isn't appearing right now. It's possible that 19986 fixed it, but I don't have a high confidence in that. Please LMK if y'all see this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants