Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow unsandboxed renderers to request new privileges (7-0-x) #19999

Merged
merged 2 commits into from Aug 29, 2019
Merged

fix: allow unsandboxed renderers to request new privileges (7-0-x) #19999

merged 2 commits into from Aug 29, 2019

Conversation

Eugeny
Copy link

@Eugeny Eugeny commented Aug 28, 2019

Description of Change

Backport of #19953

Checklist

Release Notes

Notes: no-notes

@Eugeny Eugeny requested a review from a team as a code owner August 28, 2019 08:55
@welcome
Copy link

welcome bot commented Aug 28, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 28, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 29, 2019
@jkleinsc jkleinsc changed the title fix: allow unsandboxed renderers to request new privileges fix: allow unsandboxed renderers to request new privileges (7-0-x) Aug 29, 2019
@codebytere codebytere merged commit bb8c7df into electron:7-0-x Aug 29, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 29, 2019

No Release Notes

@welcome
Copy link

welcome bot commented Aug 29, 2019

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants