fix: Revert "fix: make sure that menu bar gets focus even when you click an item to focus it first" #20019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @brenca |
deepak1556
approved these changes
Aug 29, 2019
|
Release Notes Persisted
|
MarshallOfSound
deleted the
revert-19710-brenca/menu-bar-click-focus-a11y
branch
|
I have automatically backported this PR to "5-0-x", please check out #20034 |
|
I have automatically backported this PR to "6-0-x", please check out #20035 |
|
I have automatically backported this PR to "7-0-x", please check out #20036 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #19710
As outlined in comments in that PR this is re-causing issues where when you open the menu the webContents loses focus and it is never restored. This breaks things like "copy", "paste" and the
webContents.getFocusedWebContents()method.Notes: Fixed issue where using the menu on Linux would un-focus the webContents