-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: honor cursor blink rate #20020
fix: honor cursor blink rate #20020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please implement it on Windows using GetCaretBlinkTime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or actually this seems better
https://cs.chromium.org/chromium/src/chrome/browser/renderer_preferences_util.cc?type=cs&q=GetCursorBlinkInterval&sq=package:chromium&g=0&l=123-125
#if defined(TOOLKIT_VIEWS)
prefs->caret_blink_interval = views::Textfield::GetCaretBlinkInterval();
#endif
5400120
to
f3c3f70
Compare
a112048
to
8fa05b0
Compare
8fa05b0
to
5f82958
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the updates!
@codebytere can we use |
@miniak it does wrap that method, but it also wraps things for mac and so for clarity & maintainability i’d prefer we explicitly set all three ourselves since we’d need to call the linux one separately regardless. Perhaps we could consider upstreaming the linux one into that call and then using that in the future? |
Release Notes Persisted
|
I have automatically backported this PR to "7-0-x", please check out #20044 |
I have automatically backported this PR to "5-0-x", please check out #20045 |
I have automatically backported this PR to "6-0-x", please check out #20046 |
Description of Change
Closes #10668.
Ensures that WebPreferences honor the system cursor blink rate on creation.
cc @zcbenz @nornagon @MarshallOfSound
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where cursor blink rate was not honored.