Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move ipcRenderer spec to main runner #20093

Merged
merged 3 commits into from Sep 19, 2019
Merged

test: move ipcRenderer spec to main runner #20093

merged 3 commits into from Sep 19, 2019

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Sep 3, 2019

Description of Change

Also simplify & robustify some tests. One of the tests in the suite was actually testing remote module stuff, so I moved it to the remote spec suite.

Checklist

Release Notes

Notes: none

jkleinsc
jkleinsc approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a small nit on the one test name

@nornagon nornagon merged commit e83c299 into master Sep 19, 2019
@release-clerk
Copy link

release-clerk bot commented Sep 19, 2019

No Release Notes

@nornagon nornagon deleted the move-ipc-renderer-spec branch September 19, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nornagon @jkleinsc @miniak