feat: set urgency on linux notifications #20152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
linux-notif-urgency
branch
from
5a4f279
to
7c8868a
Compare
MarshallOfSound
previously requested changes
Sep 6, 2019
There was a problem hiding this comment.
We can make this cross-platform as far as windows --> https://docs.microsoft.com/en-us/uwp/api/windows.ui.notifications.toastnotification.priority
macOS does not support changing the notificaiton priority at runtime.
codebytere
force-pushed
the
linux-notif-urgency
branch
3 times, most recently
from
82aa2b9
to
caed6a7
Compare
codebytere
changed the title
codebytere
force-pushed
the
linux-notif-urgency
branch
2 times, most recently
from
a9db090
to
0a40a19
Compare
codebytere
force-pushed
the
linux-notif-urgency
branch
from
0a40a19
to
2a3e4d7
Compare
ckerr
approved these changes
Sep 17, 2019
There was a problem hiding this comment.
@MarshallOfSound is right about making this x-platform, but it doesn't all need to happen in one PR. This PR LGTM for Linux.
Co-Authored-By: Charles Kerr <ckerr@github.com>
codebytere
force-pushed
the
linux-notif-urgency
branch
from
54e62fa
to
655eaf1
Compare
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Enable users to customize the
urgencylevels of Linux notifications.Checklist
npm testpassesRelease Notes
Notes: Added an
urgencyproperty to allow customization of Linux-based notifications.