Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use v8 serialization for ipc #20214

Merged
merged 56 commits into from Oct 9, 2019
Merged

refactor: use v8 serialization for ipc #20214

Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
0f092dc
refactor: use v8 serialization for ipc
nornagon Sep 12, 2019
f8e14c4
cloning process.env doesn't work
nornagon Sep 12, 2019
3ab77d2
serialize host objects by enumerating key/values
nornagon Sep 16, 2019
94e085b
new serialization can handle NaN, Infinity, and undefined correctly
nornagon Sep 16, 2019
a43bbbc
can't allocate v8 objects during GC
nornagon Sep 16, 2019
8301091
backport microtasks fix
nornagon Sep 16, 2019
245ee49
Merge remote-tracking branch 'origin/master' into cloneable-message-ipc
nornagon Sep 19, 2019
df429a0
fix compile
nornagon Sep 20, 2019
2738f42
fix node_stream_loader reentrancy
nornagon Sep 20, 2019
3284dcd
update subframe spec to expect undefined instead of null
nornagon Sep 20, 2019
2cbf4ca
write undefined instead of crashing when serializing host objects
nornagon Sep 20, 2019
0a52bb8
fix webview spec
nornagon Sep 20, 2019
5e0565a
fix download spec
nornagon Sep 20, 2019
40e1fad
buffers are transformed into uint8arrays
nornagon Sep 20, 2019
955c796
can't serialize promises
nornagon Sep 20, 2019
58f0cd9
fix chrome.i18n.getMessage
nornagon Sep 20, 2019
5940a3b
fix devtools tests
nornagon Sep 20, 2019
17d18f1
fix zoom test
nornagon Sep 20, 2019
bc9a3f1
fix debug build
nornagon Sep 20, 2019
08f8331
fix lint
nornagon Sep 20, 2019
02d27a7
update ipcRenderer tests
nornagon Sep 20, 2019
df7db15
Merge remote-tracking branch 'origin/master' into cloneable-message-ipc
nornagon Sep 20, 2019
bf44165
fix printToPDF test
nornagon Sep 20, 2019
b3baeae
Merge remote-tracking branch 'origin/master' into cloneable-message-ipc
nornagon Sep 23, 2019
64702c0
update patch
nornagon Sep 23, 2019
712c652
remove accidentally re-added remote-side spec
nornagon Sep 23, 2019
674bffd
wip
nornagon Sep 23, 2019
c90e09f
don't attempt to serialize host objects
nornagon Sep 23, 2019
b89750e
jump through different hoops to set options.webContents sometimes
nornagon Sep 24, 2019
2faef13
whoops
nornagon Sep 24, 2019
4404b94
fix lint
nornagon Sep 24, 2019
853e895
clean up error-handling logic
nornagon Sep 24, 2019
6162988
fix memory leak
nornagon Sep 24, 2019
9d38a1e
fix lint
nornagon Sep 24, 2019
271c41f
convert host objects using old base::Value serialization
nornagon Sep 25, 2019
5383d56
fix lint more
nornagon Sep 25, 2019
2c53cc1
fall back to base::Value-based serialization
nornagon Sep 25, 2019
6e2e6c1
remove commented-out code
nornagon Sep 25, 2019
6270ca2
add docs to breaking-changes.md
nornagon Sep 30, 2019
d3a9e1c
Update breaking-changes.md
nornagon Sep 30, 2019
bcc470a
update ipcRenderer and WebContents docs
nornagon Oct 1, 2019
a970c4d
lint
nornagon Oct 1, 2019
153c3f5
Merge remote-tracking branch 'origin/master' into cloneable-message-ipc
nornagon Oct 1, 2019
96798b4
use named values for format tag
nornagon Sep 28, 2019
7f4fbe0
save a memcpy for ~30% speedup
nornagon Sep 28, 2019
e2f7ad4
get rid of calls to ShallowClone
nornagon Sep 28, 2019
f30b3a5
extra debugging for paranoia
nornagon Sep 28, 2019
27d9963
d'oh, use the correct named tags
nornagon Oct 1, 2019
215f786
Merge remote-tracking branch 'origin/master' into cloneable-message-ipc
nornagon Oct 2, 2019
aae6c48
apparently msstl doesn't like this DCHECK
nornagon Oct 2, 2019
f033c97
funny story about that DCHECK
nornagon Oct 3, 2019
4ac4714
disable remote-related functions when enable_remote_module = false
nornagon Oct 4, 2019
a3403a5
nits
nornagon Oct 4, 2019
2d6b332
use EnableIf to disable remote methods in mojom
nornagon Oct 4, 2019
fc668b4
fix include
nornagon Oct 4, 2019
55076a3
review comments
nornagon Oct 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/browser/chrome-extension.js
View file
Open in desktop
Expand Up @@ -240,7 +240,7 @@ const getMessagesPath = (extensionId) => {

ipcMainUtils.handleSync('CHROME_GET_MESSAGES', async function (event, extensionId) {
const messagesPath = getMessagesPath(extensionId)
return fs.promises.readFile(messagesPath)
return fs.promises.readFile(messagesPath).then(b => b.toString('utf8'))
nornagon marked this conversation as resolved.
Show resolved Hide resolved
nornagon marked this conversation as resolved.
Show resolved Hide resolved
})

const validStorageTypes = new Set(['sync', 'local'])
Expand Down