Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use coordinate offsets in ShowAutofillPopup #20232

Merged
merged 2 commits into from Sep 19, 2019
Merged

fix: use coordinate offsets in ShowAutofillPopup #20232

merged 2 commits into from Sep 19, 2019

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Sep 14, 2019

Description of Change

  • Fix a popup positioning regression that caused the embed offset to be lost. Looks like this regression is pretty new from refactor: mojofy autofill renderer->browser聽#18760 and doesn't need any backport. 馃帀
  • Silence a minor clang-tidy warning about implicit type narrowing from int to float. This isn't a big deal, but the changed code is also easier to read.

CC @brenca

Checklist

Release Notes

Notes: Fixed the position of popups being created over embedded content.

@ckerr
fix: use coordinate offsets in ShowAutofillPopup
61c93d5
@ckerr
fix: silence coord int->float narrowing conversion
9e1968d 
Minor fix to silence clang-tidy warning about implicit range narrowing.
Not a huge deal but the revision is also easier to read.

clang-tidy: bugprone-narrowing-conversions
@ckerr ckerr requested a review from brenca September 14, 2019 02:41
@electron-cation electron-cation bot added the new-pr 馃尡 PR opened in the last 24 hours label Sep 14, 2019
@dnlhwrd3269

This comment has been minimized.

Sign in to view
@electron-cation electron-cation bot removed the new-pr 馃尡 PR opened in the last 24 hours label Sep 15, 2019
@codebytere codebytere merged commit 63f08fc into master Sep 19, 2019
@release-clerk
Copy link

release-clerk bot commented Sep 19, 2019

Release Notes Persisted

Fixed the position of popups being created over embedded content.

@codebytere codebytere deleted the fix-popup-bounds-offset branch September 19, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@brenca brenca Awaiting requested review from brenca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ckerr @dnlhwrd3269 @codebytere